Fix PlaylistAppendDialog showing when no local playlists exist#4345
Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom Oct 23, 2020
Merged
Fix PlaylistAppendDialog showing when no local playlists exist#4345TobiGr merged 2 commits intoTeamNewPipe:devfrom
TobiGr merged 2 commits intoTeamNewPipe:devfrom
Conversation
opusforlife2
added
bug
Stypox
reviewed
Sep 29, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you for looking into this! The changes look mostly good. :-D
app/src/main/java/org/schabi/newpipe/local/dialog/PlaylistAppendDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/dialog/PlaylistAppendDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistManager.java
Show resolved
Hide resolved
Contributor
Author
|
@Stypox I pushed your recommendations to the branch. Thanks for them! (Why didn't I think about the Runnable? xD - I'm too spoiled with Kotlin's built-in lambda as parameters ^^) |
Stypox
previously approved these changes
Sep 29, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Now code looks good to me, thank you again!
TobiGr
force-pushed
the
fix-createplaylist
branch
from
d93e263 to
32a142b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
PlaylistDAOandLocalPlaylistManagerto get an observable for checking if there is a playlistcheckPlayliststoPlaylistAppendDialogwhich gives the opportunity to react on existing playlistsFixes the following issue(s)
Testing apk
app-debug-fix-createplaylist.zip
Agreement